Add nullability checks with proper errors in TagPrefix BlockProperties#5019
Open
jurrejelle wants to merge 1 commit into
Open
Add nullability checks with proper errors in TagPrefix BlockProperties#5019jurrejelle wants to merge 1 commit into
jurrejelle wants to merge 1 commit into
Conversation
jurrejelle
added
type: bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add null check and errors for blockProperties in tagPrefix
Outcome
Helps in debugging, would have saved @Phoenixvine32908 some time lol
How Was This Tested
Game runs
Potential Compatibility Issues
Can't think of any valid reasons why either of these would be null instead of identity. there's also a valid default, shrimply don't set it